-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove command-line program, change to being library-only #1075
Comments
Assigning to Martin for a decision; I can implement if you think it's right. |
I'm OK with that. |
Do you think it's a good idea, though? |
Yes, I don't think there's value in |
CC @theseanl |
I'd be happy to work further on the CLI and getting more feedback. But as I understand, there are some ways to use tsickle via some Bazel rules, why not add pointers to that? It seemed that many build tools opensourced by Google is somehow involved with Bazel, so it seemed to be the "expected" way of using tsickle. Personally I couldn't find a comprehensive documentation on how to use tsickle and closure compiler with Bazel, and I'm eager to learn more about it. |
@alexeagle is the bazel master. The |
right, under Bazel we expect that tsc_wrapped will be the driver of the tsickle plugin. I'm okay with removing the main. |
Alex, what's the authoritative documentation that we should link to? I'd
imagine our README.md would say "Go here for tscc, go here for the bazel
rules integration".
|
I don't think our documentation is sufficient, but tsickle is mentioned on https://github.com/bazelbuild/rules_nodejs/blob/master/docs/TypeScript.md and that's probably the right spot, unless we add a new high-level doc about Bazel+TS+Closure |
This makes it more clear that the main entry point is just a demo. This also lets us drop a bunch of cruft from the main tsickle package.json. Resolves #1075, more or less.
We have a bunch of bugs here that are various forms of "the command-line tsickle program doesn't do what I want". In practice, using tsickle well requires a driver program like the Angular compiler, or maybe https://github.com/theseanl/tscc .
I think we should consider removing our command-line interface entirely and instead say to use one of these other tools. Right now our CLI tempts people into trying it, but it doesn't really work, and we don't have resources to improve it.
The text was updated successfully, but these errors were encountered: