This commit updates tsickle's JSDoc closure translation to

not attempt translating/resolving enum members multiple times.

The double lookup was introduced back then with the TS 5.x bump.

This is important because in complex applications, this may be
extremely expensive, causing double expensive lookups searching all files and their exports in a `ts.Program`.

PiperOrigin-RevId: 626365165

demo/package.json

@@ -8,7 +8,7 @@
   "dependencies": {
     "minimist": "^1.2.3",
     "tsickle": "file:../",
-    "typescript": "5.2.2"
+    "typescript": "5.4.2"
   },
   "devDependencies": {
     "@types/minimist": "1.2.0",

package.json

@@ -11,7 +11,7 @@
     "out/src/*"
   ],
   "peerDependencies": {
-    "typescript": "~5.1.5"
+    "typescript": "~5.4.2"
   },
   "devDependencies": {
     "@types/diff-match-patch": "^1.0.32",
@@ -28,7 +28,7 @@
     "source-map-support": "^0.5.19",
     "tslib": "^2.2.0",
     "tslint": "^6.1.3",
-    "typescript": "5.2.2"
+    "typescript": "5.4.2"
   },
   "scripts": {
     "build": "tsc",

src/annotator_host.ts

@@ -53,6 +53,9 @@ export interface AnnotatorHost {
  * prefix to scope symbols in externs file (see externs.ts).
  */
 export function moduleNameAsIdentifier(
-    host: AnnotatorHost, fileName: string, context = ''): string {
+  host: AnnotatorHost,
+  fileName: string,
+  context = '',
+): string {
   return host.pathToModuleName(context, fileName).replace(/\./g, '$');
 }

src/cli_support.ts

@@ -25,7 +25,10 @@ export function assertAbsolute(fileName: string) {
  * import and generates a googmodule module name for the imported module.
  */
 export function pathToModuleName(
-    rootModulePath: string, context: string, fileName: string): string {
+  rootModulePath: string,
+  context: string,
+  fileName: string,
+): string {
   fileName = fileName.replace(/(\.d)?\.[tj]s$/, '');
 
   if (fileName[0] === '.') {
@@ -37,7 +40,9 @@ export function pathToModuleName(
   // TODO(evanm): various tests assume they can import relative paths like
   // 'foo/bar' and have them interpreted as root-relative; preserve that here.
   // Fix this by removing the next line.
-  if (!path.isAbsolute(fileName)) fileName = path.join(rootModulePath, fileName);
+  if (!path.isAbsolute(fileName)) {
+    fileName = path.join(rootModulePath, fileName);
+  }
 
   // TODO(evanm): various tests assume they can pass in a 'fileName' like
   // 'goog:foo.bar' and have this function do something reasonable.
@@ -50,8 +55,10 @@ export function pathToModuleName(
   }
 
   // Replace characters not supported by goog.module.
-  const moduleName =
-      fileName.replace(/\/|\\/g, '.').replace(/^[^a-zA-Z_$]/, '_').replace(/[^a-zA-Z0-9._$]/g, '_');
+  const moduleName = fileName
+    .replace(/\/|\\/g, '.')
+    .replace(/^[^a-zA-Z_$]/, '_')
+    .replace(/[^a-zA-Z0-9._$]/g, '_');
 
   return moduleName;
 }

src/closure_externs.js

@@ -60,7 +60,7 @@ var ReadonlySet;
  * @template T
  * @extends {IThenable<T>}
  */
-function PromiseLike() {};
+function PromiseLike() {}
 
 /** @typedef {function(new:Promise)} */
 var PromiseConstructor;
@@ -94,7 +94,7 @@ var TemplateStringsArray;
 var RegExpMatchArray;
 
 /** @record */
-function ImportMeta() {};
+function ImportMeta() {}
 
 // Representations for TS' EventMap objects.
 // These are types that contain a mapping from event names to event object