Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

feat(webdriver-manager): use proxy for webdriver-manager #966

Closed
wants to merge 1 commit into from

Conversation

hankduan
Copy link
Contributor

No description provided.

@hankduan
Copy link
Contributor Author

I tests against http://www.charlesproxy.com/ already (since I don't have corp proxy), but those who need this feature please try it and let me know if it doesn't work for you.

if (argv.proxy) {
return argv.proxy;
} else if (protocol === 'https:') {
return process.env.HTTPS_PROXY || process.env.HTTP_PROXY;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to support this, or require it to be explicitly entered with --proxy? I haven't had to work behind a corporate proxy, but after a quick search using env.HTTPS_PROXY doesn't seem to be a common pattern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

responding to myself. Looked around, did find a couple uses of this, so let's keep it.

@juliemr
Copy link
Member

juliemr commented Jun 23, 2014

LGTM

@hankduan
Copy link
Contributor Author

merged with 6906c93

@nwinkler
Copy link
Contributor

I've made a couple of minor modifications here: #968

The error handling for the request was not evaluating the error variable, thus silently swallowing any errors coming from the request module.

I also added support for both lower case and upper case environment variables, i.e. (HTTPS_PROXY and https_proxy). This is in line with what tools like npm use.

@hankduan hankduan deleted the proxy branch October 6, 2014 19:54
@katlimruiz
Copy link

at first it didnt work for me.
How to solve? Set env variables as below:
$ set HTTP_PROXY=http://proxy.com:8080
$ set HTTPS_PROXY=http://proxy.com:8080
and then run your command
(in my case it was due to angular-seed, so when bower install ran, it picked up these variables)

@ericis
Copy link

ericis commented Jun 27, 2018

Doesn't work for a couple of us. We tried HTTP_PROXY and HTTPS_PROXY and setting node config proxy and still get the error: Error: tunneling socket could not be established, cause=getaddrinfo ENOTFOUND 9091 9091:80. Other internet commands are working with the above proxy settings correctly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants