Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): ensure all of label displays on safari #871

Merged
merged 1 commit into from
Jul 16, 2016
Merged

Conversation

kara
Copy link
Contributor

@kara kara commented Jul 16, 2016

Closes #795

@hansl, can you take a look? The overflow:hidden style added here seems to cut off labels in iOS. Removing it fixes the problem, and I can't seem to see any visual difference in major browsers.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 16, 2016
@hansl
Copy link
Contributor

hansl commented Jul 16, 2016

LGTM.

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 16, 2016
@kara kara merged commit c8303b4 into angular:master Jul 16, 2016
@jean-merelis
Copy link
Contributor

@hansl @kara the overflow:hidden is related to this issue #689 (comment)

My suggestion is expand .md-input-wrapper:
#863 (comment)

@mcalmus
Copy link
Contributor

mcalmus commented Jan 24, 2017

I am showing error messages via md-hint. If the message is too longer and must wrap it partially overlaps the input.

@jasonburrows
Copy link

@mcalmus me too - did you find a solution for this?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-input placeholder text is partially hidden
6 participants