refactor(select): use aria-activedescendant to manage focus #6856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
select-activedescendant
branch
from
14f5414
to
1f992ae
Compare
jelbourn
approved these changes
Sep 13, 2017
src/lib/select/select.spec.ts
Outdated
| trigger.click(); | ||
| fixture.detectChanges(); | ||
| tick(200); |
There was a problem hiding this comment.
Make constants for 200 and 500 so that the different have some semantic meaning tied to it?
crisbeto
force-pushed
the
select-activedescendant
branch
from
5f54f1b
to
624ddff
Compare
crisbeto
added
the
P1
kara
approved these changes
Sep 19, 2017
crisbeto
force-pushed
the
select-activedescendant
branch
from
624ddff
to
23a5494
Compare
crisbeto
added
action: merge
mmalerba
added
pr: needs rebase
and removed
action: merge
|
please rebase |
crisbeto
force-pushed
the
select-activedescendant
branch
from
23a5494
to
a518536
Compare
crisbeto
added
action: merge
|
Ready to go @mmalerba. |
crisbeto
force-pushed
the
select-activedescendant
branch
from
a518536
to
26fd20e
Compare
|
Needs rebase |
andrewseguin
added
pr: needs rebase
and removed
action: merge
* Refactors the select to use `aria-activedescendant` to announce the highlighted item to screen readers. Previously we would this through focus, however using focus prevents us from being able to do things like angular#3211. * Fixes a hack that was used to get a hold of the panel element using `querySelector`. Now it properly uses a `ViewChild` query, however this meant some tests had to be updated. Relates to angular#3211. Fixes angular#6690.
crisbeto
force-pushed
the
select-activedescendant
branch
from
26fd20e
to
6ea8424
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
essjay05
added a commit
to essjay05/angular-components
that referenced
this pull request
Aug 27, 2024
…iveDescendant Updates previous fix to account for previous fix angular#6856 which refactored focus on listbox to use aria-activedescendant instead to manage focus. Fixes b/285945157
essjay05
added a commit
to essjay05/angular-components
that referenced
this pull request
Aug 28, 2024
…iveDescendant Updates previous fix to account for previous fix angular#6856 which refactored focus on listbox to use aria-activedescendant instead to manage focus. Fixes b/285945157
essjay05
added a commit
to essjay05/angular-components
that referenced
this pull request
Aug 29, 2024
…iveDescendant Updates previous fix to account for previous fix angular#6856 which refactored focus on listbox to use aria-activedescendant instead to manage focus. Fixes b/285945157
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-activedescendantto announce the highlighted item to screen readers. Previously we would do this through focus, however using focus prevents us from being able to do things like feat(select): add md-select-header directive #3211.querySelector. Now it properly uses aViewChildquery, however this meant some tests had to be updated.Relates to #3211.
Fixes #6690.