feat: support strictNullChecks #3486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns on `strictNullChecks` everywhere and refactors all of the code to make it compliant. This makes us consistent with the core Angular modules which support `strictNullChecks` after 4.0. Fixes angular#3465.
crisbeto
added
blocked
googlebot
added
the
cla: yes
crisbeto
commented
Mar 7, 2017
| @@ -49,7 +49,7 @@ function _execNpmPublish(label: string): Promise<{}> { | |||
| console.log(`Publishing material...`); | |||
|
|
|||
| const command = 'npm'; | |||
| const args = ['publish', '--access', 'public', label ? `--tag` : undefined, label || undefined]; | |||
| const args = ['publish', '--access', 'public', label ? `--tag` : '', label || '']; | |||
There was a problem hiding this comment.
Note to self: this is broken and should be reworked.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 12, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
|
Closing in favor of #5094. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 12, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 12, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 12, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 12, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 13, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 14, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 16, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 17, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
jelbourn
pushed a commit
to crisbeto/material2
that referenced
this pull request
Jun 20, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 20, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
jelbourn
pushed a commit
to crisbeto/material2
that referenced
this pull request
Jun 20, 2017
Adds compatibility with strictNullChecks to the library, tests, build and various test apps. Fixes angular#3486.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns on
strictNullCheckseverywhere and refactors all of the code to make it compliant. This makes us consistent with the core Angular modules which supportstrictNullChecksafter 4.0.Fixes #3465.
Note: This is pretty conflict-prone and is blocked on a couple of things:
@angular/formsdoesn't supportstrictNullChecksas of 4.0 RC2, which means that our code won't be able to compile until it does.