fix(multiple): resolve forward ref errors #32413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combobox and listbox had some cases where they were referencing classes defined further down in the file in their queries. When the references are extracted into Angular's metadata, this can cause an error at runtime because the reference becomes eager. These changes wrap the problematic cases in `forwardRef` to resolve the issues. Fixes angular#32408.
crisbeto
requested review from
andrewseguin,
ok7sai and
wagnermaciel
and removed request for
a team
wagnermaciel
approved these changes
Nov 26, 2025
Member
Author
crisbeto
added a commit
that referenced
this pull request
Nov 26, 2025
The combobox and listbox had some cases where they were referencing classes defined further down in the file in their queries. When the references are extracted into Angular's metadata, this can cause an error at runtime because the reference becomes eager. These changes wrap the problematic cases in `forwardRef` to resolve the issues. Fixes #32408. (cherry picked from commit 9fff253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The combobox and listbox had some cases where they were referencing classes defined further down in the file in their queries.
When the references are extracted into Angular's metadata, this can cause an error at runtime because the reference becomes eager.
These changes wrap the problematic cases in
forwardRefto resolve the issues.Fixes #32408.