fix(material/button): fixes mat-icon svg size and visibility issues #32347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular#32338) Updates Angular Components Button component styling for mat-icon-buttons and all mat-fab-button variants. Only includes min-height of min-content for icons in other button variants so that when displaying svg icons such as fontawesome the height fits into the icon and is visible in safari browsers
some1awesome
requested review from
adolgachev and
ok7sai
and removed request for
a team
adolgachev
added
action: review
|
Deployed dev-app for aac40b2 to: https://ng-dev-previews-comp--pr-angular-components-32347-dev-tx8hfkd1.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed docs-preview for aac40b2 to: https://ng-dev-previews-comp--pr-angular-components-32347-docs-aiwwaoty.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
approved these changes
Nov 14, 2025
adolgachev
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Button component styling for mat-icon-buttons and all mat-fab-button variants. Only includes min-height of min-content for icons in other button variants so that when displaying svg icons such as fontawesome the height fits into the icon and is visible in safari browsers
Fixes #32338
BEFORE:
AFTER: