Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/schematics): support both application and browser builders #27875

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 2, 2023

In #27792 the schematics were updated to use the new default application builder instead of the browser builder. According to the CLI team we'll have to support both so these changes update our existing logic to account for both cases.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Oct 2, 2023
In angular#27792 the schematics were updated to use the new default `application` builder instead of the `browser` builder. According to the CLI team we'll have to support both so these changes update our existing logic to account for both cases.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2023
@crisbeto crisbeto merged commit c5ab880 into angular:main Oct 4, 2023
24 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants