Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/schematics): fix template diagnostic in table schematic #27407

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(material/schematics): fix template diagnostic in table schematic #27407

merged 1 commit into from
Jul 5, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 5, 2023

Fixes that the table schematic was producing a template diagnostic for null checking a value that doesn't need to be null checked. Also removes an unnecessary constructor.

Fixes #27329.

@crisbeto
fix(material/schematics): fix template diagnostic in table schematic
4f136ed 
Fixes that the table schematic was producing a template diagnostic for null checking a value that doesn't need to be null checked. Also removes an unnecessary constructor.

Fixes angular#27329.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Jul 5, 2023
@crisbeto crisbeto self-assigned this Jul 5, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 5, 2023
@crisbeto crisbeto merged commit 017a541 into angular:main Jul 5, 2023
crisbeto added a commit that referenced this pull request Jul 5, 2023
@crisbeto
fix(material/schematics): fix template diagnostic in table schematic (#…
35f9260 
…27407)

Fixes that the table schematic was producing a template diagnostic for null checking a value that doesn't need to be null checked. Also removes an unnecessary constructor.

Fixes #27329.

(cherry picked from commit 017a541)
stephenrca pushed a commit to stephenrca/components that referenced this pull request Aug 2, 2023
@crisbeto @stephenrca
fix(material/schematics): fix template diagnostic in table schematic (a…
578a913 
…ngular#27407)

Fixes that the table schematic was producing a template diagnostic for null checking a value that doesn't need to be null checked. Also removes an unnecessary constructor.

Fixes angular#27329.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Table Schematic Code): Build warning error in the 'table' schematic code
2 participants
@crisbeto @devversion