Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/menu): control + option + space not working on VoiceOver #27401

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix(cdk/menu): control + option + space not working on VoiceOver #27401

merged 1 commit into from
Jul 3, 2023

Commits on Jul 3, 2023

  1. fix(cdk/menu): control + option + space not working on VoiceOver 

    In angular#26296 I added a condition in the click handler for menu triggers and menu items to skip clicks dispatched by the keyboard so that they don't trigger the menu twice. The problem is that this also ends up ignoring the default keyboard shortcut that VoiceOver mentions should be used to trigger the menu (Control + Option + Space), because it ends up being dispatched as a plain `click` event and it doesn't trigger the `keydown` event at all.

These changes address the issue by removing the previous condition and inferring whether the event will trigger a click by looking at it and the element it's coming from.

Fixes angular#27376.
    @crisbeto
    crisbeto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    8d73ddf View commit details
    Browse the repository at this point in the history