fix(material/checkbox): broken appearance in some grid layouts #25197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the checkbox looked broken when placed in some CSS grid layouts. Fixes angular#25153.
crisbeto
added
P3
crisbeto
requested review from
mmalerba,
andrewseguin and
devversion
as code owners
andrewseguin
approved these changes
Jun 30, 2022
|
Is this something that should be in MDC's styles or are we doing something different with our checkbox |
|
It should probably be in MDC's styles, but it's easy enough to do in our own so I went for it. |
crisbeto
added a commit
that referenced
this pull request
Jun 30, 2022
crisbeto
added a commit
that referenced
this pull request
Jun 30, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jul 18, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.4/14.0.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.4/14.0.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.0.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1405-metal-hamster-2022-07-14) [Compare Source](angular/components@14.0.4...14.0.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [9cd5a6ad70](angular/components@9cd5a6a) | fix | **a11y:** correctly detect focus from input label ([#​25232](angular/components#25232)) | | [938aa2fa13](angular/components@938aa2f) | fix | **clipboard:** page jumping on iOS ([#​25221](angular/components#25221)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [f5bdefe6fd](angular/components@f5bdefe) | fix | **checkbox:** broken appearance in some grid layouts ([#​25197](angular/components#25197)) | | [25ce8e775c](angular/components@25ce8e7) | fix | **select:** add selected indication in high contrast mode ([#​25237](angular/components#25237)) | | [76c0e9c1cd](angular/components@76c0e9c) | fix | **tabs:** ink bar not shown in some cases ([#​25218](angular/components#25218)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [a9c7f59240](angular/components@a9c7f59) | fix | **mdc-button:** always treat icon-button content as an icon ([#​25200](angular/components#25200)) | | [7101a91ef5](angular/components@7101a91) | fix | **mdc-form-field:** ensure clip-path does not truncate label early ([#​25264](angular/components#25264)) | | [84a4e9a742](angular/components@84a4e9a) | fix | **mdc-form-field:** fix notch visual artifact ([#​25201](angular/components#25201)) | | [ce7f42b912](angular/components@ce7f42b) | fix | **mdc-form-field:** use a CSS var for the floating label scale ([#​25178](angular/components#25178)) | | [c0716784b2](angular/components@c071678) | fix | **mdc-paginator:** allow form-field density to go lower than -4 ([#​25192](angular/components#25192)) | ##### | Commit | Type | Description | | -- | -- | -- | | [89bc64a329](angular/components@89bc64a) | fix | making the parse format available for native date adapter extension ([#​25226](angular/components#25226)) | ##### multiple | Commit | Type | Description | | -- | -- | -- | | [68edf42798](angular/components@68edf42) | fix | fix disabled label style ([#​25181](angular/components#25181)) | #### Special Thanks Andrew Seguin, Kai Schönberger, Kristiyan Kostadinov, Miles Malerba, Oliver Kierepka and Paul Gschwendtner <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjExNS4wIn0=--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1463 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the checkbox looked broken when placed in some CSS grid layouts.
Fixes #25153.