fix(material-experimental/mdc-snack-bar): avoid multiple snack bars on the page if opened in quick succession #24757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
force-pushed
the
mdc-snack-bar-multiple
branch
3 times, most recently
from
d505af4 to
5483913
Compare
andrewseguin
previously approved these changes
Apr 11, 2022
andrewseguin
added
the
merge: caretaker note
crisbeto
force-pushed
the
mdc-snack-bar-multiple
branch
from
5483913 to
66d1d52
Compare
…n the page if opened in quick succession Fixes an issue where opening a snack bar while the previous one was being animated caused the former to remain in the DOM. The problem was that MDC always waits for an animation, even if it is interrupted.
crisbeto
force-pushed
the
mdc-snack-bar-multiple
branch
from
66d1d52 to
b11ab86
Compare
andrewseguin
approved these changes
May 4, 2022
This was referenced May 10, 2022
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
May 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.3.5` -> `13.3.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.3.5/13.3.6) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.3.5` -> `13.3.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.3.5/13.3.6) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1336-iridium-ire-2022-05-04) [Compare Source](angular/components@13.3.5...13.3.6) ##### material | Commit | Type | Description | | -- | -- | -- | | [6a0e6ba510](angular/components@6a0e6ba) | fix | **menu:** add constructor overloads for non-deprecated signatures ([#​24860](angular/components#24860)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [8ca629dc7e](angular/components@8ca629d) | fix | **mdc-snack-bar:** avoid multiple snack bars on the page if opened in quick succession ([#​24757](angular/components#24757)) | | [d6f9db37b0](angular/components@d6f9db3) | fix | **mdc-table:** add inherit background to rows ([#​24867](angular/components#24867)) | #### Special Thanks Andrew Seguin, Daniil Dubrava, Jeremy Elbourn, Kristiyan Kostadinov and Paul Gschwendtner <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1342 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced May 29, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where opening a snack bar while the previous one was being animated caused the former to remain in the DOM. The problem was that MDC always waits for an animation, even if it is interrupted.
Caretaker note: Fixes internal issue b/225379279