-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/chips): update chip-list describedby to match input #24292
feat(material/chips): update chip-list describedby to match input #24292
Conversation
7c3c16d
to
292c99c
Compare
292c99c
to
7dcc788
Compare
Fixes angular#16209: ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field
7dcc788
to
9b3c211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Really another feature as part of this PR is that users are now able to add additional
accessibility descriptions (through aria-describedby
) on the select, without it being accidentally overidden.
cc. @crisbeto for an additional review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…gular#24292) Fixes angular#16209: ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates MatChipList to be consistent with MatInput, and fixes ExpressionChangedAfterItHasBeenCheckedError that occurs when chip-lists are content-projected into a mat-form-field, e.g.
My use-case was creating a wrapper around
mat-form-field
to house various Mat-* formcontrol types.MatSelect could use the same update.