fix(material/input): do not override existing aria-describedby value #19587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
Accessibility
googlebot
added
the
cla: yes
devversion
commented
Jun 10, 2020
devversion
force-pushed
the
fix/input-preserve-existing-aria-describedby-value
branch
3 times, most recently
from
5d0da4a to
57ce77d
Compare
mmalerba
reviewed
Jun 16, 2020
| * Value of `aria-describedby` that should be merged with the described-by ids | ||
| * which are set by the form-field. | ||
| */ | ||
| readonly userAriaDescribedBy?: string; |
There was a problem hiding this comment.
can we add a bit about this to the docs?
There was a problem hiding this comment.
yeah, that's fair. Added it to the guide and updated our custom control example.
mmalerba
approved these changes
Jun 16, 2020
| This method is used by the `<mat-form-field>` to specify the IDs that should be used for the | ||
| `aria-describedby` attribute of your component. The method has one parameter, the list of IDs, we | ||
| just need to apply the given IDs to our host element. | ||
| This method is used by the `<mat-form-field>` to set element ids that should be used for the |
There was a problem hiding this comment.
Nice, I think this makes it a lot more clear why both properties exist / what they're for
devversion
added
the
P3
devversion
force-pushed
the
fix/input-preserve-existing-aria-describedby-value
branch
2 times, most recently
from
d8e4bc6 to
34a5f33
Compare
|
@devversion can you rebase when you get a chance? |
devversion
force-pushed
the
fix/input-preserve-existing-aria-describedby-value
branch
from
34a5f33 to
b1908a7
Compare
|
@jelbourn Done |
The form-field notifies controls whenever hints or errors have been displayed. It does this, so that controls like the input can refresh their `aria-describedby` value to point to the errors and hints. This currently has the downside of overriding existing `aria-describedby` values that have been manually set by developers. We could fix this by reading the initial value and merging it with the ids received from the form-field.
… value Address feedback
… value Add documentation
devversion
force-pushed
the
fix/input-preserve-existing-aria-describedby-value
branch
from
b1908a7 to
af8c35f
Compare
|
This is green now and rebased again. |
wagnermaciel
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The form-field notifies controls whenever hints or errors have
been displayed. It does this, so that controls like the input
can refresh their
aria-describedbyvalue to point to the errorsand hints.
This currently has the downside of overriding existing
aria-describedbyvalues that have been manually set bydevelopers. We could fix this by reading the initial value
and merging it with the ids received from the form-field.
Fixes #19528