Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox) should be disabled when *any* disabled value makes the component disabled, *except* for false. #1402

Closed
wants to merge 3 commits into from
Closed

fix(checkbox) should be disabled when *any* disabled value makes the component disabled, *except* for false. #1402

wants to merge 3 commits into from

Conversation

dharmeshpipariya-zz
Copy link

@dharmeshpipariya-zz dharmeshpipariya-zz commented Oct 2, 2016 •
edited
Loading

fix(checkbox) should be disabled when any disabled value makes the component disabled, except for false.

@dharmeshpipariya
fix(checkbox, input, slide-toggle, slider) should be disabled when *a…
b264a85 
…ny* disabled value makes the component disabled, *except* for false.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2016
@devversion
Copy link
Member

devversion commented Oct 2, 2016 •
edited
Loading

I'm curious why this change is necessary when @BooleanFieldValue is already used.

The slide-toggle for example seems to work as expected

@dharmeshpipariya-zz dharmeshpipariya-zz changed the title fix(checkbox, input, slide-toggle, slider) should be disabled when *any* disabled value makes the component disabled, *except* for false. fix(checkbox) should be disabled when *any* disabled value makes the component disabled, *except* for false. Oct 4, 2016
@jelbourn
Copy link
Member

jelbourn commented Oct 5, 2016

@BooleanFieldValue is going away in #1290 (which needs rebase). Can you just leave me a comment there to add the fix to checkbox?

@jelbourn jelbourn closed this Oct 5, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dharmeshpipariya-zz @devversion @jelbourn @googlebot @dharmeshpipariya