Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(VIRTUAL-SCROLL): In append only mode, when scrolling fast, list is jumping to start #25077

Closed
1 task
McKlobasa opened this issue Jun 15, 2022 · 1 comment · Fixed by #25097
Closed
1 task

bug(VIRTUAL-SCROLL): In append only mode, when scrolling fast, list is jumping to start #25077

McKlobasa opened this issue Jun 15, 2022 · 1 comment · Fixed by #25097
Assignees
@crisbeto
Labels
area: cdk/scrolling P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@McKlobasa
Copy link

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

Screen.Recording.2022-06-15.at.08.03.33.mov

When scrolling through example for appendOnly on documentation site (https://material.angular.io/cdk/scrolling/overview), the list acts glitchy. It is constantly jumping back to the begining.

Reproduction

Steps to reproduce:

  1. add appendOnly attribute
  2. scroll fast

Expected Behavior

It shouldn't do that.

Actual Behavior

It is jumping back to the start of the list.

Environment

  • Angular:
  • CDK/Material: at least from 12 to 14
  • Browser(s): Chrome v100
  • Operating System (e.g. Windows, macOS, Ubuntu): macOs
@McKlobasa McKlobasa added the needs triage This issue needs to be triaged by the team label Jun 15, 2022
@crisbeto crisbeto self-assigned this Jun 15, 2022
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent area: cdk/scrolling and removed needs triage This issue needs to be triaged by the team labels Jun 15, 2022
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 17, 2022
@crisbeto
fix(cdk/scrolling): content jumping in appendOnly mode
dc08edc 
We were creating the `transform` string before adjusting the offset for `appendOnly` mode which was causing the list to jump down before being reset on the next scroll event.

These changes resolve the issue by moving the offset adjustment up to before the `transform`.

Fixes angular#25077.
@crisbeto crisbeto mentioned this issue Jun 17, 2022
Merged
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker has pr and removed action: merge The PR is ready for merge by the caretaker labels Jun 17, 2022
crisbeto added a commit that referenced this issue Jun 18, 2022
@crisbeto
fix(cdk/scrolling): content jumping in appendOnly mode (#25097)
2ad1677 
We were creating the `transform` string before adjusting the offset for `appendOnly` mode which was causing the list to jump down before being reset on the next scroll event.

These changes resolve the issue by moving the offset adjustment up to before the `transform`.

Fixes #25077.

(cherry picked from commit f6bcbb1)
crisbeto added a commit that referenced this issue Jun 18, 2022
@crisbeto
fix(cdk/scrolling): content jumping in appendOnly mode (#25097)
f6bcbb1 
We were creating the `transform` string before adjusting the offset for `appendOnly` mode which was causing the list to jump down before being reset on the next scroll event.

These changes resolve the issue by moving the offset adjustment up to before the `transform`.

Fixes #25077.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: cdk/scrolling P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cdk/scrolling): content jumping in appendOnly mode crisbeto/material2
2 participants
@crisbeto @McKlobasa