Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MatRangeDateSelectionModel should be excluded from public API #21985

Closed
MursalovAltun opened this issue Feb 23, 2021 · 3 comments · Fixed by #22056 or ToWipf/jasmarty#155
Closed

MatRangeDateSelectionModel should be excluded from public API #21985

MursalovAltun opened this issue Feb 23, 2021 · 3 comments · Fixed by #22056 or ToWipf/jasmarty#155
Assignees
@crisbeto
Labels
area: material/datepicker docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@MursalovAltun
Copy link

Documentation Feedback

Any usage example of injectable service MatRangeDateSelectionModel

Affected documentation page: https://material.angular.io/components/datepicker/examples
@MursalovAltun MursalovAltun added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Feb 23, 2021
@jelbourn
Copy link
Member

@crisbeto is this class mostly used internally?

@jelbourn jelbourn added needs: clarification The issue does not contain enough information for the team to determine if it is a real bug area: material/datepicker labels Feb 23, 2021
@crisbeto
Copy link
Member

Yes, the model is used internally to sync up the value between the various datepicker components. We should mark it as @docs-private so that it doesn't show up in the docs.

@jelbourn jelbourn changed the title docs-bug(MatDateRangePicker): No docs for MatRangeDateSelectionModel MatRangeDateSelectionModel should be excluded from public API Feb 24, 2021
@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs: clarification The issue does not contain enough information for the team to determine if it is a real bug needs triage This issue needs to be triaged by the team labels Feb 24, 2021
@crisbeto crisbeto self-assigned this Feb 28, 2021
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 28, 2021
@crisbeto
fix(material/datepicker): hide date selection model from docs
43b41b0 
* Hides some symbols related to the date selection model from the public API docs.
* Fixes that `MatDateSelectionModel` was marked as a directive, rather than an injectable.

Fixes angular#21985.
@crisbeto crisbeto mentioned this issue Feb 28, 2021
Merged
wagnermaciel pushed a commit that referenced this issue Mar 2, 2021
@crisbeto
fix(material/datepicker): hide date selection model from docs (#22056)
8497bb1 
* Hides some symbols related to the date selection model from the public API docs.
* Fixes that `MatDateSelectionModel` was marked as a directive, rather than an injectable.

Fixes #21985.
wagnermaciel pushed a commit that referenced this issue Mar 2, 2021
@crisbeto @wagnermaciel
fix(material/datepicker): hide date selection model from docs (#22056)
92de837 
* Hides some symbols related to the date selection model from the public API docs.
* Fixes that `MatDateSelectionModel` was marked as a directive, rather than an injectable.

Fixes #21985.

(cherry picked from commit 8497bb1)
This was referenced Mar 6, 2021
Closed
Closed
Merged
Merged
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
area: material/datepicker docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
3 participants
@jelbourn @crisbeto @MursalovAltun