Skip to content

feat(functions): Add options param to httpsCallable functions #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesdaniels merged 2 commits into from
Nov 11, 2020
Merged

feat(functions): Add options param to httpsCallable functions #2434

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ab59d
feat(functions): Add options param to httpsCallable functions
NothingEverHappens Apr 29, 2020
ab5c617
Merge branch 'master' into feat/functions-https-callable-options
jamesdaniels Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/functions/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { map, switchMap, shareReplay, tap, observeOn } from 'rxjs/operators';
import { FirebaseOptions, FirebaseAppConfig, FIREBASE_APP_NAME, ɵlazySDKProxy, ɵPromiseProxy, ɵAngularFireSchedulers } from '@angular/fire';
import { FIREBASE_OPTIONS, ɵfirebaseAppFactory } from '@angular/fire';
import { functions } from 'firebase/app';
import { HttpsCallableOptions } from '@firebase/functions-types';

export const ORIGIN = new InjectionToken<string>('angularfire2.functions.origin');
export const REGION = new InjectionToken<string>('angularfire2.functions.region');
Expand Down Expand Up @@ -38,12 +39,12 @@ export class AngularFireFunctions {
shareReplay({ bufferSize: 1, refCount: false }),
);

this.httpsCallable = <T=any, R=any>(name: string) =>
this.httpsCallable = <T = any, R = any>(name: string, options?: HttpsCallableOptions) =>
(data: T) => from(functions).pipe(
observeOn(schedulers.outsideAngular),
switchMap(functions => functions.httpsCallable(name)(data)),
switchMap(functions => functions.httpsCallable(name, options)(data)),
map(r => r.data as R)
)
);

return ɵlazySDKProxy(this, functions, zone);

Expand Down