remote-config InjectionTokens miss-match between docs and code.

[mcroker]

Version info

AngularFire:
@angular/fire 6.0.0

Other (e.g. Ionic/Cordova, Node, browser, operating system):

Ionic:

Ionic CLI : 5.4.16
Ionic Framework : @ionic/angular 5.3.3
@angular-devkit/build-angular : 0.901.12
@angular-devkit/schematics : 9.1.12
@angular/cli : 9.1.12
@ionic/angular-toolkit : 2.3.0

Capacitor:

Capacitor CLI : 2.4.2
@capacitor/core : 2.4.2

Cordova:

Cordova CLI : not installed
Cordova Platforms : not available
Cordova Plugins : not available

Utility:

cordova-res : not installed
native-run (update available: 1.2.2) : 1.0.0

System:

ios-deploy : 1.11.0
NodeJS : v12.14.0 (/opt/local/bin/node)
npm : 6.13.4
OS : macOS Catalina
Xcode : Xcode 12.1 Build version 12A7403

How to reproduce these conditions

I believe the putting it all together example in the remote-config readme doesn't align with the code. It references DEFAULT_CONFIG and REMOTE_CONFIG_SETTINGS; whereas in the code these are actually defined as SETTING and DEFAULT. The import statement isn't included in snippet so it could be that they were renamed (but if that's the case I suggest inclusion of the include would help the example.)

https://github.com/angular/angularfire/blob/master/docs/remote-config/getting-started.md

@NgModule({
  imports: [
    AngularFireModule.initializeApp(environment.firebase),
    AngularFireRemoteConfigModule
  ],
  providers: [
    { provide: DEFAULT_CONFIG, useValue: { enableAwesome: true } },
    {
      provide: REMOTE_CONFIG_SETTINGS,
      useFactory: () => isDevMode() ? { minimumFetchIntervalMillis: 10_000 } : {}
    }
  ]
})
export class AppModule { }

https://github.com/angular/angularfire/blob/master/src/remote-config/remote-config.ts

export declare const SETTINGS: InjectionToken<remoteConfig.Settings>;
export declare const DEFAULTS: InjectionToken<ConfigTemplate>;

[mcroker]

There's a further compile issue in the readme example code which comes up in strict mode, due to a signature miss-match between filterFresh() and scanToObject(). I've seen this before where typescript hasn't done a great job of detecting the right type for overloaded rxjs pipe functions.

This fails

    remoteConfig$ = this.remoteConfig.changes.pipe(
        filterFresh(172_800_000), 
        first(),
        scanToObject({
            enableAwesome: true,
            titleBackgroundColor: 'blue',
            titleFontSize: 12
        }) 

With this error

[ng]     ERROR in src/app/services/firebase-capacitor-proxy.service.ts:21:9 - error TS2345: Argument of type 'OperatorFunction<Parameter | Parameter[], Parameter | Parameter[]>' is not assignable to parameter of type 'OperatorFunction<Parameter | Parameter[], Parameter>'.
[ng]       Type 'Parameter | Parameter[]' is not assignable to type 'Parameter'.
[ng]         Type 'Parameter[]' is missing the following properties from type 'Parameter': key, fetchTimeMillis, _source, _value, and 4 more.
[ng]     
[ng]     21         first(),
[ng]                ~~~~~~~

Forcing a map to parameter rather than parameter[] resolves

    remoteConfig$ = this.remoteConfig.changes.pipe(
        filterFresh(172_800_000),
        map(i => i as Parameter),    // <-------- Not really very type-safe!
        first(),
        scanToObject({
            enableAwesome: true,
            titleBackgroundColor: 'blue',
            titleFontSize: 12
        })
    );

[jamesdaniels]

First issue addressed. I'll take a peek at the second.