This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(equals): fix #1648 correctly compare objects with undefined member variables #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
given a = {} and b = {x:undefined} then
angular.equals(a, b) should be true
angular.equals(b, a) should be true (this happened before)
Signed-off-by: Gonzalo Ruiz de Villa <[email protected]>
|
I've changed the commit message because it wasn't clear at all. |
|
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): For corporations (print, sign and scan+email, fax or mail): |
|
I already signed it when I sent PR #1692 |
IgorMinar
added a commit
to IgorMinar/angular.js
that referenced
this pull request
Jan 18, 2013
previously:
a = {};
b = {x:undefined};
angular.equals(a, b) == angular.equals(b, a) // returns false.
both should return false because these objects are not equal.
unlike in implemented in angular#1695 the comparison should be stricter
and return false not true. if we need to relax this in the future
we can always do so.
Closes angular#1648
|
I took a slightly different approach and fixed this with 124e9b8 thanks for sharing your solution though |
IgorMinar
added a commit
that referenced
this pull request
Jan 18, 2013
previously:
a = {};
b = {x:undefined};
angular.equals(a, b) == angular.equals(b, a) // returns false.
both should return false because these objects are not equal.
unlike in implemented in #1695 the comparison should be stricter
and return false not true. if we need to relax this in the future
we can always do so.
Closes #1648
IgorMinar
added a commit
that referenced
this pull request
Jan 18, 2013
previously:
a = {};
b = {x:undefined};
angular.equals(a, b) == angular.equals(b, a) // returns false.
both should return false because these objects are not equal.
unlike in implemented in #1695 the comparison should be stricter
and return false not true. if we need to relax this in the future
we can always do so.
Closes #1648
jamessharp
pushed a commit
to jamessharp/angular.js
that referenced
this pull request
Jan 18, 2013
previously:
a = {};
b = {x:undefined};
angular.equals(a, b) == angular.equals(b, a) // returns false.
both should return false because these objects are not equal.
unlike in implemented in angular#1695 the comparison should be stricter
and return false not true. if we need to relax this in the future
we can always do so.
Closes angular#1648
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
given a = {} and b = {x:undefined} then
angular.equals(a, b) should be true
angular.equals(b, a) should be true (this happened before)
Closes: #1648