chore(*): update Node.js from 8 to 12, update some dependencies #16915

mgol · 2019-11-15T15:43:32Z

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

Node.js 8 is used to build/test AngularJS.

What is the new behavior (if this is a feature change)?

Node.js 12 is used to build/test AngularJS.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

The commit message follows our guidelines
~~Fix/Feature: Docs have been added/updated~~
~~Fix/Feature: Tests have been added; existing tests pass~~

Other information:

Node.js 8 ends its support at the end of 2019. Node 12 will be supported
until April 2022 which is way past AngularJS end of support.

Some dependencies needed to be updated to make them work in Node.js 12.

TODO:

Migrate to Gulp v4 😱

gkalpak

LGTM (as long as Travis is happy 😱)

More updates are needed

gkalpak · 2020-02-02T09:26:47Z

~~Rebased on master to see if c8a6e84 would fix the failures.~~
Nevermind, I just realized gulp 3 is not compatible with Node.js v12.

Splaktar · 2020-05-19T23:00:12Z

You can support Gulp 3.x in NodeJS v12/14 using the approach that we used in AngularJS Material: angular/material#11892

Upgrading to Gulp v4 is generally considered too time intensive and not worth the effort for older projects that are close to ending LTS.

Splaktar

The primordials failures with Gulp v3 are caused by NodeJS 12+ no longer accepting the natives override. The PR I linked above has another approach that solves these issues with graceful-fs.

package.json

mgol · 2020-05-20T09:43:45Z

The primordials failures with Gulp v3 are caused by NodeJS 12+ no longer accepting the natives override. The PR I linked above has another approach that solves these issues with graceful-fs.

That's a great idea, thanks! I'll have a look later.

petebacondarwin · 2020-05-20T13:18:02Z

Adding a resolution for graceful-fs works at treat.

googlebot · 2020-05-20T13:24:41Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2020-05-20T13:24:41Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

petebacondarwin · 2020-05-20T13:26:01Z

@googlebot I consent

googlebot · 2020-05-20T13:26:06Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2020-05-20T13:26:06Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Splaktar · 2020-05-20T15:09:17Z

Looks like there's a duplicate Googlebot here. We had this problem in AngularJS Material too. I think that there was one configured for the repo and one for the org. We were able to resolve it. I don't know if this affects only this PR or all PRs in the repo.

@josephperrott maybe dev-infra can resolve easily?

Node.js 8 ends its support at the end of 2019. Node 12 will be supported until April 2022 which is way past AngularJS end of support. Some dependencies needed to be updated to make them work in Node.js 12.

Splaktar

LGTM. Just a note that Chrome M83 is the latest stable now and NodeJS 12.16.3 is the latest LTS.

Splaktar · 2020-05-22T19:01:15Z

protractor-circleci-conf.js

+  capabilitiesForSauceLabs({
+    browserName: 'chrome',
+    platform: 'OS X 10.14',
+    version: '81'


Chrome Stable just hit 83.

According to this https://saucelabs.com/platform/supported-browsers-devices SauceLabs only has Chrome 81 available right now.

This commit gets rid of all references to Travis and, belatedly, Jenkins. Now all CI is done on CircleCI and releases are run locally. The CI no longer updates the docs and code.angularjs.org for jobs that are not on the `master` branch. During releases, the docs and code should be uploaded manually.

gkalpak

Post-merge review 😁
Mostly some questions.

gkalpak · 2020-05-24T14:17:02Z

package.json

@@ -98,11 +99,17 @@
    "sorted-object": "^1.0.0",
    "stringmap": "^0.2.2"
  },
-  "dependencies": {},
+  "dependencies": {
+    "firebase": "^7.14.4",


Why do we need firebase as a dependency?

Oops. I think that got included when I was messing about with trying out firebase deployments...

firebase-tools makes sense as a dev dependency 😄

gkalpak · 2020-05-24T14:18:26Z

package.json

+  "dependencies": {
+    "firebase": "^7.14.4",
+    "firebase-tools": "^8.3.0",
+    "node-glob": "^1.2.0"


Why do we need these three to be dependencies (vs devDependencies)?

Similarly - I added this by accident.

gkalpak · 2020-05-24T14:40:14Z

scripts/release/release.sh

@@ -36,7 +36,6 @@ function init {



Shouldn't this file be executable?

Absolutely! I forgot to re-apply the chmod.

gkalpak · 2020-05-24T14:40:35Z

scripts/release/undo-release.sh

@@ -38,4 +38,4 @@ function run {
  phase publish


Shouldn't this file be executable?

gkalpak · 2020-05-24T14:45:04Z

test/e2e/tests/anchor-scroll.spec.js

@@ -123,6 +123,8 @@ describe('$anchorScroll', function() {
      var lastAnchor = anchors.last();
      var lastAnchorId = 'anchor-5';

+      if (browser.params.browser === 'firefox') return;


Why this? Are the tests not working on Firefox? Or is $anchorScroll() not working correctly on Firefox?
It would be helpful to have a comment explaining at least.

gkalpak · 2020-05-24T15:15:26Z

.circleci/config.yml

+    steps:
+      - custom_attach_workspace
+      - init_environment
+      - run: yarn -s grunt ci-checks


Why the -s here (but not elsewhere)?

I copied it from the angular/angular project where it is used extensively. Then I forgot about it. I'll remove it because I don't think it makes much difference and is confusing if not used consistently.

gkalpak · 2020-05-24T15:23:33Z

.circleci/config.yml

+          filters:
+            branches:
+              only:
+                - latest


Is latest a special value? Are there any docs on how it works?

Previously deployments of the "latest" build, i.e. the releases that have a value of latest in the dist-tag property of package.json also triggered deployment of the docs to a firebase hosting, and also a special version of the code to snapshot-stable.

This is more difficult in CircleCI, so I had this idea that we would simply keep a new latest git branch updated to the latest stable release, which would then trigger the deployments.

I never got it fleshed out properly - and now I am thinking, given the status of the project, that we can just run manual deployments when we run the release. WDYT?

Why is it more difficult in CircleCI. It seems quite straight forward to me (just check package.json > distTag and abort the job if it is not latest).

Hmm, I guess that could work. I was thinking of ways to avoid running the job in the first place.

gkalpak · 2020-05-24T15:30:02Z

scripts/travis/build.sh

-    #   the commit is tagged
-    #   - or the branch is "master"
-    #   - or the branch distTag from package.json is "latest" (i.e. stable branch)
-    if [[ "$TRAVIS_TAG" != '' || "$TRAVIS_BRANCH" == master || "$DIST_TAG" == latest ]]; then


Has this logic been replicated in the new setup? I only see the corresponding job be run on branches master and latest (whatever that means 😁). What about tagged commits?

This logic has not been mapped over 1 to 1. See #16915 (comment)

A tagged commit corresponds to a release, right? So if our release process includes deployment of docs and code, then we are done. The only missing piece is the dist-tag updates...

gkalpak · 2020-05-24T15:32:38Z

scripts/travis/build.sh

-    fi
-
-    if [[ "$DEPLOY_DOCS" == true || "$DEPLOY_CODE" == true ]]; then
-      grunt prepareDeploy


I see that grunt prepareDeploy is run for both DEPLOY_CODE and DEPLOY_DOCS here. In the new setup, it is only run in the deploy-docs job (but not the deploy-code one. Is that intended?

This is a follow-up to angular#16915, cleaning up `.circleci/config.yml` (pinning Docker images of executors, removing unused code, etc.).

This is a follow-up to angular#16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

This is a follow-up to #16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

soffieswan044 · 2021-09-10T18:08:49Z

AngularJS is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c for more detail.

Does this PR fix a regression since 1.7.0, a security flaw, or a problem caused by a new browser version?

What is the current behavior? (You can also link to an open issue here)

Node.js 8 is used to build/test AngularJS.

What is the new behavior (if this is a feature change)?

Node.js 12 is used to build/test AngularJS.

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

The commit message follows our guidelines

~~Fix/Feature: Docs have been added/updated~~

~~Fix/Feature: Tests have been added; existing tests pass~~

Other information:

Node.js 8 ends its support at the end of 2019. Node 12 will be supported
until April 2022 which is way past AngularJS end of support.

Some dependencies needed to be updated to make them work in Node.js 12.

TODO:

Migrate to Gulp v4 😱

mgol added the type: chore label Nov 15, 2019

mgol added this to the 1.7.x milestone Nov 15, 2019

mgol self-assigned this Nov 15, 2019

googlebot added the cla: yes label Nov 15, 2019

gkalpak previously approved these changes Nov 15, 2019

View reviewed changes

mgol force-pushed the node-12 branch 2 times, most recently from 27017bb to eea94b1 Compare November 15, 2019 16:10

mgol changed the title ~~chore(*): Update Node.js from 8 to 12, update some dependencies~~ chore(*): update Node.js from 8 to 12, update some dependencies Nov 15, 2019

gkalpak force-pushed the node-12 branch from eea94b1 to 1a72605 Compare February 2, 2020 09:26

mgol force-pushed the node-12 branch from 1a72605 to 6b8896d Compare February 2, 2020 21:25

Splaktar suggested changes May 19, 2020

View reviewed changes

package.json Show resolved Hide resolved

package.json Show resolved Hide resolved

petebacondarwin modified the milestones: 1.7.x, 1.8.x May 20, 2020

petebacondarwin force-pushed the node-12 branch from 6b8896d to 1ce0aa8 Compare May 20, 2020 13:24

googlebot added cla: no and removed cla: yes labels May 20, 2020

googlebot added cla: yes and removed cla: no labels May 20, 2020

petebacondarwin force-pushed the node-12 branch from 1ce0aa8 to 3fa1c3b Compare May 20, 2020 13:38

petebacondarwin force-pushed the node-12 branch 9 times, most recently from 495a877 to bfe4b99 Compare May 22, 2020 16:15

mgol and others added 4 commits May 22, 2020 18:08

chore(*): update Node.js from 8 to 12, update some dependencies

43c3e5b

Node.js 8 ends its support at the end of 2019. Node 12 will be supported until April 2022 which is way past AngularJS end of support. Some dependencies needed to be updated to make them work in Node.js 12.

chore(*): update protractor to latest version

c4b79d5

chore(*): update saucelabs browsers

9c810eb

test(*): fix up some tests for Firefox

974700a

petebacondarwin force-pushed the node-12 branch from bfe4b99 to 35de7fe Compare May 22, 2020 17:09

Splaktar approved these changes May 22, 2020

View reviewed changes

petebacondarwin force-pushed the node-12 branch from 35de7fe to 5e7d1f7 Compare May 23, 2020 08:11

petebacondarwin force-pushed the node-12 branch from 5e7d1f7 to a0488b3 Compare May 23, 2020 12:25

petebacondarwin merged commit a0488b3 into angular:master May 23, 2020

mgol deleted the node-12 branch May 23, 2020 13:58

gkalpak reviewed May 24, 2020

View reviewed changes

gkalpak added a commit to gkalpak/angular.js that referenced this pull request May 24, 2020

chore(CircleCI): clean up CircleCI config

4dbaa2e

This is a follow-up to angular#16915, cleaning up `.circleci/config.yml` (pinning Docker images of executors, removing unused code, etc.).

gkalpak added a commit to gkalpak/angular.js that referenced this pull request May 24, 2020

chore(*): clean up package.json and CircleCI config

dbed54c

This is a follow-up to angular#16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

gkalpak mentioned this pull request May 24, 2020

chore(*): clean up package.json and CircleCI config #17033

Closed

gkalpak added a commit to gkalpak/angular.js that referenced this pull request May 24, 2020

chore(*): clean up package.json and CircleCI config

af421b3

This is a follow-up to angular#16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

gkalpak mentioned this pull request May 24, 2020

chore(*): clean up package.json and CircleCI config #17034

Merged

gkalpak added a commit to gkalpak/angular.js that referenced this pull request May 24, 2020

chore(*): clean up package.json and CircleCI config

c763c40

This is a follow-up to angular#16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

gkalpak added a commit to gkalpak/angular.js that referenced this pull request May 25, 2020

chore(*): clean up package.json and CircleCI config

3f2d8a9

This is a follow-up to angular#16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

gkalpak added a commit that referenced this pull request May 26, 2020

chore(*): clean up package.json and CircleCI config

295213d

This is a follow-up to #16915, cleaning up `package.json` and `.circleci/config.yml` and making release scripts executable.

chore(*): update Node.js from 8 to 12, update some dependencies #16915

chore(*): update Node.js from 8 to 12, update some dependencies #16915

Conversation

mgol commented Nov 15, 2019 • edited Loading

AngularJS is in LTS mode

gkalpak left a comment

Choose a reason for hiding this comment

gkalpak commented Feb 2, 2020 • edited Loading

Splaktar commented May 19, 2020

Splaktar left a comment

Choose a reason for hiding this comment

mgol commented May 20, 2020

petebacondarwin commented May 20, 2020

googlebot commented May 20, 2020

googlebot commented May 20, 2020

petebacondarwin commented May 20, 2020

googlebot commented May 20, 2020

googlebot commented May 20, 2020

Splaktar commented May 20, 2020

Splaktar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gkalpak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Splaktar May 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petebacondarwin May 24, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soffieswan044 commented Sep 10, 2021

AngularJS is in LTS mode

mgol commented Nov 15, 2019 •

edited

Loading

gkalpak commented Feb 2, 2020 •

edited

Loading

Splaktar May 26, 2020 •

edited

Loading

petebacondarwin May 24, 2020 •

edited

Loading