Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Fixing this strange bug with innerHTML and <tr> tags #1314

Closed
wants to merge 2 commits into from
Closed

Fixing this strange bug with innerHTML and <tr> tags #1314

wants to merge 2 commits into from

Conversation

applmak
Copy link

@applmak applmak commented Aug 30, 2012

There's this bug (at least in Chrome) where the original $('

' + stuff + '
') wouldn't do the right thing when stuff was a string that started with, say, a . This change fixes that bug, but hasn't been rigorously tested in any way. I'm just curious if this is the right approach for the fix.

You can see what I think of as a bug here http://jsfiddle.net/A2FPR/2/

There's this bug (at least in Chrome) where the original $('<div>' + stuff + '</div>') wouldn't do the right thing when stuff was a string that started with, say, a <tr>. This change fixes that bug, but hasn't been rigorously tested in any way.
@mhevery
Copy link
Contributor

mhevery commented Aug 31, 2012

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement).

CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form):
http://code.google.com/legal/individual-cla-v1.0.html

For corporations (print, sign and scan+email, fax or mail):
http://code.google.com/legal/corporate-cla-v1.0.html

@mhevery
Copy link
Contributor

mhevery commented Sep 12, 2012

ping? we need to have CLA signed before we can continue with merging this.

@jbdeboer
Copy link
Contributor

Your test is failing: http://ci.angularjs.org/job/angular.js-james/7/console

Could you take a look at it?

This bug is effecting others, e.g. issue #1459

@marco-m-alves
Copy link

I think this might be related.

I created a scriptTransclude directive to handle transclusion of td's into tr's.

http://jsbin.com/otogih/18/edit

@jbdeboer
Copy link
Contributor

I talked to @applmak off-line and he feels that this PR is on the right track, but there is more work to do.

I'm closing this PR to keep the queue clean but would invite others to tackle this particular issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants