Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

feature/issue: more useful module.animation callbacks #4993

Closed
amitport opened this issue Nov 17, 2013 · 5 comments
Closed

feature/issue: more useful module.animation callbacks #4993

amitport opened this issue Nov 17, 2013 · 5 comments

Comments

@amitport
Copy link

module.animation-enter only intercepts after the element has been added to the DOM

this is a problem when you want to animate the movement of the elements that change location after the new element insertion

module.animation-leave only intercepts before the element has been removed from the DOM

again this is a problem when you want to animate the movement of the elements change location after the new element was removed (this is less problematic since I manage to run the movement animation using $timeout in a function returned from 'leave' (but still... it's an ugly hack))

@matsko
Copy link
Contributor

matsko commented Nov 22, 2013

Hehe I was just thinking of this solution and bam then I came across this issue.

With 1.2.0, we have beforeAddClass and beforeRemoveClass, however, I would like to do the same thing for beforeEnter, beforeMove and perhaps afterLeave. These would all be in the same place where you define an animation with module.animation(...).

Does this fit your needs?

@amitport
Copy link
Author

beforeEnter and afterLeave will be great for my use case (animating the movement of siblings whose position is affected by the insertion/removal)

thanks!

@ghost ghost assigned matsko Jan 4, 2014
@IgorMinar
Copy link
Contributor

@matsko is this a feature request for 1.3?

@matsko
Copy link
Contributor

matsko commented Jan 6, 2014

Yes. before(enter, leave, move) is for 1.3. The DOM callbacks are for 1.2.x.

@matsko
Copy link
Contributor

matsko commented Jan 22, 2014

The callbacks are in place and in 1.2.10 there will be a $animate:close callback.

matsko added a commit to matsko/angular.js that referenced this issue Jan 22, 2014
@matsko matsko closed this as completed in ca6b7d0 Jan 24, 2014
juliemr pushed a commit to juliemr/angular.js that referenced this issue Jan 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants