Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate Box Shadow disappears while animation is going. #4902

Closed
mfrancis107 opened this issue Nov 12, 2013 · 2 comments
Closed

ngAnimate Box Shadow disappears while animation is going. #4902

mfrancis107 opened this issue Nov 12, 2013 · 2 comments
Assignees
@matsko
Labels
component: ngAnimate type: bug
Milestone
1.2.2 - conscious...

Comments

@mfrancis107
Copy link

When $animate.enabled == true box shadows do not appear while the animations is going. They reappear once transition is complete.

See Plunker.
http://plnkr.co/edit/0hnTAZJjfo2ao2whiIzr?p=preview
@deakster
Copy link

I can confirm this is caused by the same issue that is described in #4892 . When I patch $animate.addClass/removeClass to perform the domOperation immediately, the box shadow stays visible correctly.

@matsko
Copy link
Contributor

matsko commented Nov 12, 2013

Actually no, this has to do with the fallback class mechanism put in place to capture hanging animations. ngAnimate adds a clip property to make sure the animation does something and ends. The clip property in this case erases the styling for box-shadow. Guess we'll need to remove this fallback property system.

@ghost ghost assigned matsko Nov 14, 2013
matsko added a commit to matsko/angular.js that referenced this issue Nov 15, 2013
@matsko
fix(ngAnimate): use a fallback CSS property that doesn't break existi…
187b054 
…ng styles

The clip property seems to remove the box-shadow property when an absolute
positioned animation is ongoing. This fix changes the property to be border-spacing
which is also very underused. The border-spacing CSS property is only visible
when border-collapse is set to separate.

Closes angular#4902
@matsko matsko mentioned this issue Nov 15, 2013
Closed
@matsko matsko mentioned this issue Nov 19, 2013
Closed
@matsko matsko closed this as completed in 1d50663 Nov 21, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@matsko @jamesdaily
fix(ngAnimate): use a fallback CSS property that doesn't break existi…
2e04ad5 
…ng styles

The clip property seems to remove the box-shadow property when an absolute
positioned animation is ongoing. This fix changes the property to be border-spacing
which is also very underused. The border-spacing CSS property is only visible
when border-collapse is set to separate.

Closes angular#4902
Closes angular#5030
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@matsko @jamesdaily
fix(ngAnimate): use a fallback CSS property that doesn't break existi…
cdbd366 
…ng styles

The clip property seems to remove the box-shadow property when an absolute
positioned animation is ongoing. This fix changes the property to be border-spacing
which is also very underused. The border-spacing CSS property is only visible
when border-collapse is set to separate.

Closes angular#4902
Closes angular#5030
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate type: bug
Projects
None yet
Milestone
1.2.2 - consciousness-inertia
3 participants
@matsko @deakster @mfrancis107