-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Animation scatters ng-views all around the page #4732
Comments
The problem here is that you don't have any styles changing. http://plnkr.co/edit/iPAhbdZhiLU8V8SjIwZI?p=preview This is an issue since it gives the developer the wrong idea. Working on a separate fix to ensure the animation always closes. RC2 used timeouts and RC3+ uses CSS events. |
Yes, that much I've realized, though the issue persists, if you only change ng-enter style and omit ng-leave altogether: |
…class is missing Closes angular#4732 Closes angular#4490
…class is missing Closes angular#4732 Closes angular#4490
The issue still presents in v1.2.0. Please reopen. http://plnkr.co/edit/mHiBWV68zullBwSl0krC?p=preview If you click links fast enough, animations do not close. |
Another plunkr: http://plnkr.co/edit/s4Q8R80TzRaBdYccgvPr?p=preview FF24. When ng-leave transition duration is 0.01s, animations are hanging. The same with 0.02s, 0.03s, 0.04s. Google Chrome is OK. |
Once this PR goes through: #5015 then please try again to see if the issue persists and then I'll reopen if necessary. |
The issue still presents in angular v1.2.5 with FF 25. Google Chrome seems to be ok. |
Can you have a test with this patch? Here are the files: https://s3.amazonaws.com/angularjs-dev/ng-animate-ie-10/angular.js |
…class is missing Closes angular#4732 Closes angular#4490
…class is missing Closes angular#4732 Closes angular#4490
http://plnkr.co/edit/s4Q8R80TzRaBdYccgvPr?p=preview
If you click [1] and [2] links by turns, you'll notice that more and more div[ng-view] elements continue to appear on the page.
rc.2 is OK. The regression was introduced by commit 32ad292 - refactor($animate): use CSS3 transition/animation events instead of $timeouts to track ongoing animations
The text was updated successfully, but these errors were encountered: