Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(@angular/cli): remove webpack nodeJS globals shimming #9812

Merged
merged 1 commit into from
Feb 28, 2018
Merged

refactor(@angular/cli): remove webpack nodeJS globals shimming #9812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions packages/@angular/cli/models/webpack-configs/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,6 @@ export function getBrowserConfig(wco: WebpackConfigOptions) {
deployUrl: buildOptions.deployUrl,
}),
]),
node: {
fs: 'empty',
global: true,
crypto: 'empty',
tls: 'empty',
net: 'empty',
process: true,
module: false,
clearImmediate: false,
setImmediate: false
}
node: false,
};
}
5 changes: 0 additions & 5 deletions packages/@angular/cli/models/webpack-configs/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,6 @@ export function getCommonConfig(wco: WebpackConfigOptions) {
warnings: buildOptions.verbose,
safari10: true,
compress: {
// Disabled because of an issue with Mapbox GL when using the Webpack node global:
// https://github.com/mapbox/mapbox-gl-js/issues/4359#issuecomment-303880888
// https://github.com/angular/angular-cli/issues/5804
// https://github.com/angular/angular-cli/pull/7931
typeofs : false,
pure_getters: buildOptions.buildOptimizer,
// PURE comments work best with 3 passes.
// See https://github.com/webpack/webpack/issues/2899#issuecomment-317425926.
Expand Down