Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): set correct mainFields for ng test when targeting … #8500

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

devoto13
Copy link
Contributor

…es2015

Added test fails without the fix with the error described in the linked issue.

Fixes #8379

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@devoto13 devoto13 force-pushed the es2015-tests branch 2 times, most recently from 346e8e5 to 5ab300b Compare November 15, 2017 18:37
@googlebot
Copy link

CLAs look good, thanks!

@devoto13
Copy link
Contributor Author

devoto13 commented Nov 15, 2017

It looks like tests failed because of angular/devkit@6d7a7ea#diff-39adc46a1150e1880c972fc429a66aa6. Will rebase once it is fixed in master.

…es2015

Added test fails without the fix with the error described in the linked issue.

Fixes angular#8379
@devoto13 devoto13 closed this Nov 17, 2017
@devoto13 devoto13 reopened this Nov 17, 2017
@filipesilva filipesilva self-assigned this Nov 20, 2017
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@hansl hansl merged commit 2607578 into angular:master Nov 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subject cannot be invoked without 'new' when testing
4 participants