Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): use require for @angular/core check #7601

Merged
merged 1 commit into from
Sep 5, 2017

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Sep 5, 2017

This should help with linked node_module scenarios.

Fix #3864
Should help with #7097

@filipesilva
Copy link
Contributor Author

@intellix can you check if this helps in your yarn workspaces repro?

This should help with linked node_module scenarios.
@intellix
Copy link
Contributor

intellix commented Sep 5, 2017

Works :)

@filipesilva filipesilva merged commit 1d79620 into angular:master Sep 5, 2017
@filipesilva filipesilva deleted the use-require-assert branch September 5, 2017 20:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular-cli doesn't work when node_modules is located in a parent directory
4 participants