Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 18, 2025

This fixes an issue where relative includes didn't work when using backslashes in windows.

Closes #31829


Green run: https://github.com/angular/angular-cli/actions/runs/19467531139/job/55706346256?pr=31854

Running test "tests/vitest/include" (1 of 1)...
==========================================================================================
Running `npm "install" "vitest@^4.0.8" "jsdom@^27.1.0" "--save-dev"` [silent]...
CWD: D:\tmp_dir\angular-cli-e2e-1UgCNT\e2e-test\test-project
==========================================================================================
Running `ng "test" "--include" "D:\tmp_dir\angular-cli-e2e-1UgCNT\e2e-test\test-project\src\app\app.spec.ts"` [silent]...
CWD: D:\tmp_dir\angular-cli-e2e-1UgCNT\e2e-test\test-project
==========================================================================================
Running `ng "test" "--include" "src\app\app.spec.ts"` [silent]...
CWD: D:\tmp_dir\angular-cli-e2e-1UgCNT\e2e-test\test-project
==========================================================================================

Refactored the vitest e2e include test to also include testing relative paths.
@alan-agius4 alan-agius4 force-pushed the add-include-relative branch 5 times, most recently from 25b1b3f to b8390bd Compare November 18, 2025 13:16
This fixes an issue where relative includes didn't work when using backslashes in windows.

Closes angular#31829
@alan-agius4 alan-agius4 requested a review from clydin November 18, 2025 13:24
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 18, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review November 18, 2025 13:24
@alan-agius4 alan-agius4 changed the title test: refactor vitest include e2e test fix(@angular/build): normalize --include paths to posix Nov 18, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 18, 2025
@ngbot
Copy link

ngbot bot commented Nov 18, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Nov 19, 2025
@ngbot
Copy link

ngbot bot commented Nov 19, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dgp1130 dgp1130 merged commit d5b4d03 into angular:main Nov 19, 2025
69 of 76 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 19, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vitest unit test fails when run with --include command option with relative path

3 participants