Skip to content

test: improve vitest e2e test stability and performance #31853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

test: improve vitest e2e test stability and performance #31853

merged 1 commit into from
Nov 19, 2025

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 18, 2025

  • Use Chrome binary from rules_browsers for Playwright in Vitest browser tests for hermetic testing and avoids re-downloads of chrome.
  • Batch ng generate commands in e2e tests to improve performance.
  • Remove now redundant chromium install commands from e2e tests.

@alan-agius4
test: improve vitest e2e test stability and performance
9629fee 
- Use Chrome binary from `rules_browsers` for Playwright in Vitest browser tests for hermetic testing and avoids re-downloads of chrome.
- Batch `ng generate` commands in e2e tests to improve performance.
- Remove now redundant chromium install commands from e2e tests.
@alan-agius4 alan-agius4 requested a review from clydin November 18, 2025 09:35
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 18, 2025
@alan-agius4 alan-agius4 force-pushed the large-coverage branch 2 times, most recently from 2f1c4af to 85f2994 Compare November 18, 2025 12:41
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 18, 2025
@ngbot
Copy link

ngbot bot commented Nov 18, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Nov 19, 2025
@ngbot
Copy link

ngbot bot commented Nov 19, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dgp1130 dgp1130 merged commit f72e8da into angular:main Nov 19, 2025
67 of 75 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 19, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @dgp1130 @clydin