Skip to content

Conversation

@alan-agius4
Copy link
Collaborator

The best practices markdown file is now sourced directly from @angular/core/resources/best-practices.md. This change eliminates duplication and ensures consistency across packages.

  • packages/angular/cli/src/commands/mcp/resources/best-practices.md is now generated from the @angular/core resource.
  • packages/schematics/angular/ai-config/files/__rulesName__.template is also generated from the @angular/core resource, with additional frontmatter.

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 18, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review November 18, 2025 09:16
The best practices markdown file is now sourced directly from `@angular/core/resources/best-practices.md`. This change eliminates duplication and ensures consistency across packages.

- `packages/angular/cli/src/commands/mcp/resources/best-practices.md` is now generated from the `@angular/core` resource.
- `packages/schematics/angular/ai-config/files/__rulesName__.template` is also generated from the `@angular/core` resource, with additional frontmatter.
@alan-agius4 alan-agius4 force-pushed the best-practice-use-angular-core branch from 7ce4811 to e0011b5 Compare November 18, 2025 09:18
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Nov 18, 2025
@ngbot
Copy link

ngbot bot commented Nov 19, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dgp1130 dgp1130 merged commit 240d96c into angular:main Nov 19, 2025
33 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 19, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants