feat(@angular-devkit/build-angular): add externalDependencies to the esbuild browser builder
#23390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
commented
Jun 17, 2022
| @@ -0,0 +1,542 @@ | |||
| { | |||
There was a problem hiding this comment.
Note: while technically we could use allOf ex:
{
"allOf": [
{
"properties": {
"externalDependencies": {...}
}
},
{ "$ref": "../browser/schema.json" }
]
}quicktype doesn't merge this properly. See: glideapps/quicktype#1840
alan-agius4
removed
the
action: review
alan-agius4
force-pushed
the
feat-esbuild-external
branch
from
a75dceb to
96a5617
Compare
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
feat-esbuild-external
branch
from
96a5617 to
a9a25bc
Compare
This commit adds browser-esbuild infra.
…e esbuild browser builder This commit add a new `externalDependencies` option to the experimental browser builder. Dependencies listed in this option will not be included in the final bundle, instead the user would need to provide them at runtime using import maps or another method. Closes angular#23322
alan-agius4
force-pushed
the
feat-esbuild-external
branch
from
a9a25bc to
80d76ac
Compare
clydin
approved these changes
Jun 21, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add a new
externalDependenciesoption to the experimental browser builder.Dependencies listed in this option will not be included in the final bundle, instead the user would need to provide them at runtime using import maps or another method.
Closes #23322