Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add time logs in _listLazyRoutesFromProgram #13159

Merged
merged 1 commit into from
Dec 11, 2018
Merged

refactor: add time logs in _listLazyRoutesFromProgram #13159

merged 1 commit into from
Dec 11, 2018

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 10, 2018

refactor: add time logs in _listLazyRoutesFromProgram

Add these time logs as at the moment we are not logging anything for the discovery lazy loaded modules

@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin December 10, 2018 09:45
@alan-agius4 alan-agius4 changed the title refactor: resuse old ng program for lazy route discovery refactor: add time logs in _listLazyRoutesFromProgram Dec 10, 2018
Add these time logs as at the moment we are not logging anything for the discovery lazy loaded modules
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Dec 10, 2018
@kyliau kyliau merged commit 603e6f4 into angular:master Dec 11, 2018
@alan-agius4 alan-agius4 deleted the ngtools_ng_program branch December 11, 2018 20:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants