-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular CLI SSR Configuration removes trailing comma in AppConfig, resulting in Syntax Errors #26911
Labels
area: @schematics/angular
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Comments
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jan 23, 2024
… to app config This fixes an issue which caused the new provider to be added in the position of the traling comma. With this change the trailing comma is retained. Closes angular#26911
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jan 23, 2024
… to app config This fixes an issue which caused the new provider to be added in the position of the trailing comma. With this change the trailing comma is retained. Closes angular#26911
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Jan 23, 2024
… to app config This fixes an issue which caused the new provider to be added in the position of the trailing comma. With this change the trailing comma is retained. Closes angular#26911
alan-agius4
added a commit
that referenced
this issue
Jan 23, 2024
… to app config This fixes an issue which caused the new provider to be added in the position of the trailing comma. With this change the trailing comma is retained. Closes #26911
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: @schematics/angular
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Command
add
Is this a regression?
The previous version in which this bug was not present was
No response
Description
Upon running
ng add @angular/ssr
the following happened:provideClientHydration
was not placed on a new line and the trailing comma was removed, resulting in a syntax error.Minimal Reproduction
run:
ng add @angular/ssr
Exception or Error
Your Environment
Anything else relevant?
No response
The text was updated successfully, but these errors were encountered: