Skip to content

Commit

Permalink
build: ensure ng-dev command works on windows
Browse files Browse the repository at this point in the history
Apparently the `ng-dev` command does not work with Git Bash on windows
because of the environment variable being set. We should use `ts-node`
directly to avoid this issue, and also avoid the `$PWD` access which
might not work depending on the shell.

Also on the dev-infra side we would need to remove the ts-node shebang
and leave the responsibility to the consumer project.

(cherry picked from commit 507a7e2)
  • Loading branch information
devversion authored and dgp1130 committed Jun 21, 2022
1 parent 5e960ce commit 3dc7427
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"build:bazel": "node ./bin/devkit-admin build-bazel",
"build-tsc": "tsc -p tsconfig.json",
"lint": "eslint --cache --max-warnings=0 \"**/*.ts\"",
"ng-dev": "TS_NODE_PROJECT=$PWD/.ng-dev/tsconfig.json node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
"ng-dev": "ts-node --esm --project .ng-dev/tsconfig.json node_modules/@angular/dev-infra-private/ng-dev/bundles/cli.mjs",
"templates": "node ./bin/devkit-admin templates",
"validate": "node ./bin/devkit-admin validate",
"postinstall": "yarn webdriver-update && yarn husky install",
Expand Down

0 comments on commit 3dc7427

Please sign in to comment.