fix: 🐛 don't call needLoadMoreData on last row with cellNav #7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unable to edit the last row if both cellNav and infiniteScroll were present (caused infinte refresh loop with scrollDown)
Bug Fixes
Commit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
marcelo-portugal
approved these changes
Jul 31, 2023
mportuga
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent needLoadMoreData from being called on lastRow when cellNav is present. I did this because I was unable to edit the last row if both cellNav and infiniteScroll were present (caused infinte refresh loop with scrollDown).