Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default exporterExcelCustomFormatter shouldn't return null #6785

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Default exporterExcelCustomFormatter shouldn't return null #6785

merged 2 commits into from
Jun 29, 2018

Commits on Jun 29, 2018

  1. Default exporterExcelCustomFormatter shouldn't return null 

    The default exporterExcelCustomFormatter custom function currently returns null which causes errors downstream. It should return the unmodified docDefinition

This should fix issue angular-ui#6774
    @sujeetpillai
    sujeetpillai authored Jun 29, 2018
    Configuration menu
    Copy the full SHA
    8ce6911 View commit details
    Browse the repository at this point in the history

  2. Correcting the fix 

    The fix is supposed to be for exporterExcelCustomFormatter not exporterExcelHeader
    @sujeetpillai
    sujeetpillai authored Jun 29, 2018
    Configuration menu
    Copy the full SHA
    fb9070b View commit details
    Browse the repository at this point in the history