Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S… #6722

Merged
merged 1 commit into from
May 11, 2018
Merged

fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S… #6722

merged 1 commit into from
May 11, 2018

Conversation

mportuga
Copy link
Member

…tring.toUpperCase and .toLowerC

This will allow us to support angular 1.7 when it becomes available.

fix #6715

fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S…
5010ff0 
…tring.toUpperCase and .toLowerC

This will allow us to support angular 1.7 when it becomes available.

fix #6715
@mportuga mportuga merged commit a41677a into master May 11, 2018
@mportuga mportuga deleted the fix/angular17 branch May 11, 2018 02:29
oklymenk
oklymenk reviewed May 14, 2018
View reviewed changes
Copy link

@oklymenk oklymenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about line 903:

var capsName = angular.uppercase(name.charAt(0)) + name.substr(1);

@mportuga
Copy link
Member Author

I missed that. Thanks

@enderdickerson
Copy link

@mportuga Is there a commit with @oklymenk's change included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oklymenk oklymenk oklymenk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

angular.lowercase and angular.uppercase methods removed in angular 1.7
3 participants
@mportuga @enderdickerson @oklymenk