fix(memory_leaks): Ensuring events get unbound when grid is destroyed. #5913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a set of destroy listeners that unbinds jquery events when the grid is destroyed. #4203
dlgski
reviewed
Dec 27, 2016
| @@ -1278,6 +1278,11 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC | |||
| for ( var i = mouseWheeltoBind.length; i; ) { | |||
| $elm.on(mouseWheeltoBind[--i], cbs[fn]); | |||
| } | |||
| $elm.on('$destroy', function unbindEvents() { | |||
| for ( var i = mouseWheeltoBind.length; i; ) { | |||
| $elm.off(mouseWheeltoBind[--i], cbs[fn]); | |||
There was a problem hiding this comment.
this looks like it may be something that needs additional refactoring
dlgski
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a set of destroy listeners that unbinds jquery events when the grid is destroyed.
#4203