Fixes and improvements in configureColumnWidths #508
Conversation
…ly take effect on-the-fly if using the ng-grid-layout plugin) - Columns sized with * or % now expand / shrink as other * or %-based columns are hidden / shown - Re-ordered columns now keep their width setup - Bugfixes in configureColumnWidths - Fixed "asteriskNum" so it no longer includes hidden columns (was checking .visible on a columnDefs column instead of the matching ngColumn) - Fixed "totalWidth" so it no longer includes hidden columns when using px values for width (was checking .visible on a columnDefs column instead of the matching ngColumn) - Fixed ngColumn width being initialized to undefined when using "auto" for width, regardless of "minWidth" settings (was checking .minWidth on a columnDefs column instead of the matching ngColumn) - ng-grid-layout plugin now listens to 'ngGridEventColumns' events and then rebuilds the grid Renamed "col" to "colDef" in configureColumnWidths() in the places where "col" was a column from "columnDefs". It made it clearer for me whether I was referring to a ngColumn or a column from columnDefs. There were a couple of bugs caused by that (col.visible incorrectly accessed on columnDefs objects instead of ngColumns, and the like).
- The plugin couldn't shrink the grid, only grow it - Using domUtilityService.UpdateGridLayout instead of grid.refreshDomSizes which correctly grows the grid if it's been shrunk (e.g. when paging to the last page and it has few rows + the plugin has a smaller min. height than what's needed on the other pages)
|
This is really great - I've been looking for this functionality sincy a long time ago. Great work! |
|
@ebbe-brandstrup Thanks for the pull request. I'm going to look at/test it more when I get home today. |
|
@jonricaurte Thanks, much appreciated. If anything strikes you as odd or doesn't work, please let me know and I'll change things accordingly. We're depending on these changes in a project I'm working on atm. and would of course like them to be part of an official release at some point to be able to stay on the main repo. Looking forward to your feedback. |
|
I pushed a 2.0.7 branch last night that made a few changes to get rid of the subtracting for border width on columns. Instead of using borders, I'm using vertical bars so if someone sets a width to be 400px for a column, the column will actually be 400px, not 401-402px due to the border. This caused the horizontal overflowing to happen producing a horizontal scrollbar. I also moved percent calculation ahead of the asterisks calculation cause I feel percent calculation takes a higher priority, and the asterisks calculations will then be able to fill the remaining space instead of overflowing the viewport. If everything looks good on your pull request (so far it does), I'll merge your changes into the 2.0.7 branch and write some tests. |
|
Here is the 2.0.7 branch: https://github.com/angular-ui/ng-grid/tree/2.0.7 |
|
I merged your changes into the 2.0.7 branch. Can you test out your grids with the other changes in it? It can be accessed through the previous comment's link. |
|
Great! On my way into the office now and then I'll pull the 2.0.7 branch Thanks a lot for being so quick on this - and for ng-grid in the first On Wednesday, June 26, 2013, jonricaurte wrote:
|
|
Yup :D I'm going to close this request and point everyone to #511 |
|
Great! I've been running with 2.0.7 for the last couple of hours and On Wed, Jun 26, 2013 at 7:40 AM, jonricaurte [email protected]:
|
configureColumnWidths
Renamed "col" to "colDef" in configureColumnWidths() in the places where "col" was a column from "columnDefs". It made it clearer for me whether I was referring to a ngColumn or a column from columnDefs. There were a couple of bugs caused by that (col.visible incorrectly accessed on columnDefs objects instead of ngColumns, and the like).
ng-grid-layout plugin
ng-grid-flexible-height plugin