fix(core): fix #4180 by adding validity check for minWidth and maxWidth #4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
merlinchen
commented
Aug 19, 2015
merlinchen
commented
- String and number are both allowed.
- Valid String value will parse into number properly.
- Invalid String value will throw an error.
| if (!angular.isString(minOrMaxWidth) && !angular.isNumber(minOrMaxWidth)) { | ||
| self[name] = ((name === 'minWidth') ? 30 : 9000); | ||
| } else if (angular.isString(minOrMaxWidth)) { | ||
| if (minOrMaxWidth.match(/^(\d+)$/)) { |
There was a problem hiding this comment.
Can you add a comment describing this regex?
|
This looks good. Squash it into one commit and I'd have no problem merging it in. |
…and maxWidth - String and number are both allowed. - Valid String value will parse into number properly. - Invalid String value will throw an error.
merlinchen
force-pushed
the
col-min-and-max-width-validity-check
branch
from
b16c2b7
to
5b03cb2
Compare
|
Squashed. |
JLLeitschuh
added a commit
that referenced
this pull request
Aug 24, 2015
…ty-check fix(core): fix #4180 by adding validity check for minWidth and maxWidth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.