Convert menu item title names to readable column names #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eserve consistency with column headers that lack display names.
PaulL1
added a commit
that referenced
this pull request
Jul 14, 2015
Convert menu item title names to readable column names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the columnDef config object doesn't include a displayName property and grid.options.enableGridMenu = true, the grid menu titles default to the name property provided in the columnDef config object. This results in an inconsistency between the column headers and the grid menu titles.
More specifically, the column headers are converted to friendly display names via gridUtil.readableColumnName, whereas the menu titles simply display the name property.
To remain consistent, the menu title should also create a friendly display name via gridUtil.readableColumnName.