Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll bug when scrolling down #1926 #2762

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Conversation

foxx9
Copy link
Contributor

@foxx9 foxx9 commented Feb 12, 2015

When scrolling up, the page continues scrolling when the grid's scroller reaches the top which is good. But the same doesn't happen when the grid's scroller is at the bottom

It seems that the fireThrottledScrollingEvent function had a conflict with the browser scrolling behavior #1926

>When scrolling up, the page continues scrolling when the grid's scroller reaches the top which is good. But the same doesn't happen when the grid's scroller is at the bottom

It seems that the fireThrottledScrollingEvent function had a conflict with the browser scrolling behavior
@PaulL1
Copy link
Contributor

PaulL1 commented Feb 12, 2015

Very excellent. I tried and failed to fix that one!!

PaulL1 added a commit that referenced this pull request Feb 12, 2015
scroll bug when scrolling down  #1926
@PaulL1 PaulL1 merged commit ad47a7f into angular-ui:master Feb 12, 2015
c0bra added a commit that referenced this pull request Feb 16, 2015
My commit 382f0ae broke a fix from #2762. This change puts the fix back.

This should fix #1926
@foxx9 foxx9 deleted the patch-1 branch February 24, 2015 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants