Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Viewport height with rowHeight and Custom Header #6671

Closed
anuragsimgeker opened this issue Apr 13, 2018 · 2 comments · Fixed by #6773
Closed

Incorrect Viewport height with rowHeight and Custom Header #6671

anuragsimgeker opened this issue Apr 13, 2018 · 2 comments · Fixed by #6773
Labels
stale type: docs

Comments

@anuragsimgeker
Copy link
Contributor

Extending the Custom Header tutorial with setting a custom rowHeight leads to incorrect calculation of the .ui-grid-viewport and .ui-grid CSS height, causing the last row to be cut off slightly.

http://plnkr.co/edit/uFL4ByULhTIxu5z9IEqj?p=preview

Expected

screen shot 2018-04-13 at 12 28 43 pm

Actual

screen shot 2018-04-13 at 12 27 55 pm
@anuragsimgeker
Copy link
Contributor Author

I found a grid option headerRowHeight which solves this issue. Why is this not documented?

@stale
Copy link

stale bot commented Jun 12, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 12, 2018
mportuga pushed a commit that referenced this issue Jun 21, 2018
docs(ui-grid.info): Added missing documentation.
7b7ef3c 
Documented headerRowHeight, sort priority, setRowsDirty and savePagination.

closes #4098, closes #5518, closes #5661, closes #6671
@mportuga mportuga mentioned this issue Jun 21, 2018
Merged
mportuga pushed a commit that referenced this issue Jun 22, 2018
@mportuga
docs(ui-grid.info): Added missing documentation.
71c3db8 
Documented headerRowHeight, sort priority, setRowsDirty and savePagination.

closes #4098, closes #5518, closes #5661, closes #6671
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
docs(ui-grid.info): Added missing documentation.
399bf4c 
Documented headerRowHeight, sort priority, setRowsDirty and savePagination.

closes angular-ui#4098, closes angular-ui#5518, closes angular-ui#5661, closes angular-ui#6671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(ui-grid.info): Added missing documentation. angular-ui/ui-grid
2 participants
@anuragsimgeker @mportuga