Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate IDs when using "ui-grid-selection" #6096

Closed
dburgener-ipayables opened this issue Mar 20, 2017 · 3 comments · Fixed by #6684
Closed

Duplicate IDs when using "ui-grid-selection" #6096

dburgener-ipayables opened this issue Mar 20, 2017 · 3 comments · Fixed by #6684

Comments

@dburgener-ipayables
Copy link

dburgener-ipayables commented Mar 20, 2017

When I use "ui-grid-selection", the div that holds the column for the checkboxes, has the same ID as the div that holds the rest of the columns. This fails ADA compliance. I am using v3.1.1

image

@mportuga
Copy link
Member

Is this issue still reproducible in v4.0.3?

@dburgener-ipayables
Copy link
Author

@mportuga I just upgraded to 4.0.4, and the issue is still there.

@mportuga
Copy link
Member

mportuga commented May 1, 2018

The issue still exists for rows.

@mportuga mportuga self-assigned this May 1, 2018
mportuga pushed a commit that referenced this issue Jun 18, 2018
This change will maintain the fix for issue #6096, but ensure that the body container maintain the
same id that it had before it in order to allow for an easier upgrade for those who wrote their own
automation for UI-Grid using the previous ID. This also updates the render container to start using
the controllerAs paradigm on its template.
mportuga pushed a commit that referenced this issue Jun 18, 2018
This change will maintain the fix for issue #6096, but ensure that the body container maintain the
same id that it had before it in order to allow for an easier upgrade for those who wrote their own
automation for UI-Grid using the previous ID. This also updates the render container to start using
the controllerAs paradigm on its template.
@mportuga mportuga closed this as completed Aug 4, 2018
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
This change will maintain the fix for issue angular-ui#6096, but ensure that the body container maintain the
same id that it had before it in order to allow for an easier upgrade for those who wrote their own
automation for UI-Grid using the previous ID. This also updates the render container to start using
the controllerAs paradigm on its template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants