Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit on Focus should change to Edit box on Single-click and On Focus #521

Closed
doliver3 opened this issue Jun 30, 2013 · 2 comments
Closed

Comments

@doliver3
Copy link

Edit on Focus should change editable cells to an edit box (cell should go white in a text box) as soon as the cell gets focus (tab) or from a Single-click.

Double-click and 'change to edit box' after user starts typing is way too late.

Currently the grid cell only changes to an edit cell when the user Double-Clicks or when the user starts typing something while the focus is on the cell. This is way, way too late to use double-clicks or user typing to put the cell into edit mode visually.

  1. The user doesn't know they are in edit mode so the user could think it is safe to type something and even hit the tab key and then they saved a value that they did not intend to save.
  2. The user has no idea that the cell is in edit mode so they don't know that they can type and edit values.

The edit mode of the cell must be visible as soon as the cell gets focus or user single-clicks - this is how most other software and grids work.

The way the ng-grid is delaying telling the user they are in edit mode currently creates a really bad user experience. When the user is in edit mode on a cell they need to know immediately - it is not useful to tell them after they have started typing something or to force them to double-click before they know that they are in edit mode.

The user needs immediate visual feedback that the cell is in edit mode as soon as the focus arrives in the cell or they single click on the cell. Ng-grid should not wait until the user starts typing a different value to put the cell visually into edit mode. It should be in edit mode as soon as the user tabs into the cell or single clicks in the cell. By visually in edit mode, I mean that the background should change color to an edit box and the text should appear highlighted - like it does now when you start typing a value or double-click.

I'm just requesting that ng-grid work like other grids and software and let the user know immediately that they are in edit mode. The user needs to visually know when their typing will have an effect Before they start typing the new cell value.

@jonricaurte
Copy link
Contributor

There is an example now here: http://angular-ui.github.io/ng-grid/

@jonricaurte
Copy link
Contributor

You need to use 2.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants