-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template for ui-grid incorrectly sets last row's bottom border #4413
Comments
I see this has been around for a long time, I've come up with a slight tweak to this that should achieve the result that the logic here seemed to be trying to create, given the getTotalRowHeight function doesn't exist: Replace I'll create a PR for this. |
RobPierce
added a commit
to RobPierce/ui-grid
that referenced
this issue
Dec 21, 2017
The logic that sets the bottom-border-width for the last row calls a function that doesn't exist - grid.getTotalRowHeight() (issue logged in angular-ui#4413) so I've updated it slightly to calculate this value using the grid.getVisibleRowCount() multiplied by grid.options.rowHeight which should achieve the desired effect of the original logic.
mportuga
pushed a commit
that referenced
this issue
Dec 22, 2017
The logic that sets the bottom-border-width for the last row calls a function that doesn't exist - grid.getTotalRowHeight() (issue logged in #4413) so I've updated it slightly to calculate this value using the grid.getVisibleRowCount() multiplied by grid.options.rowHeight which should achieve the desired effect of the original logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The bottom border on the last row is never made visible because the binding expression references grid.getTotalRowHeight() which isn't defined.
The text was updated successfully, but these errors were encountered: