Disable sort on movable columns not working #2154

PierreProdel · 2014-11-19T07:50:14Z

When using ui-grid-move-columns directive, clicking on a header cell always trigger sort, even if sorting on the column is disabled.

PaulL1 · 2014-11-19T21:50:40Z

Is this a duplicate of #1815? @juri, have you already looked at this?

juri · 2014-11-20T06:23:26Z

You probably meant @jpuri? I can't recall using any of this code.

jpuri · 2014-11-20T09:46:37Z

Hey,
I am looking at this one.

jpuri · 2014-11-20T10:13:20Z

I have submitted PR #2164 that should fix this issue.

PaulL1 · 2014-11-21T03:53:09Z

#2164 is merged, @PierreProdel, could you check this is resolved, and if so close?

PierreProdel · 2014-11-21T08:08:52Z

Seems ok to me. Thanks for the quick correction

PaulL1 added this to the 3.0 milestone Nov 19, 2014

PaulL1 added the type: bug label Nov 19, 2014

jpuri pushed a commit to jpuri/ng-grid that referenced this issue Nov 20, 2014

angular-ui#2154

15146ce

jpuri mentioned this issue Nov 20, 2014

#2154 #2164

Merged

PaulL1 added a commit that referenced this issue Nov 20, 2014

Merge pull request #2164 from jpuri/master

3c0434b

#2154

PierreProdel closed this as completed Nov 21, 2014

jpuri pushed a commit to jpuri/ng-grid that referenced this issue Dec 2, 2014

angular-ui#2154

72c200f

Provide feedback