Skip to content

Commit

Permalink
Revert "chore: update changelog" and "chore: Release v4.9.2"
Browse files Browse the repository at this point in the history 
* This reverts commit 2607dc6.
* This reverts commit 6a2c7c3.
  • Loading branch information
Portugal committed Dec 4, 2020
1 parent 2607dc6 commit 3a4a27f
Show file tree
Hide file tree
Showing 68 changed files with 75 additions and 265 deletions.
12 changes: 0 additions & 12 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)


### Bug Fixes

* **tree-base:** grouping showing duplicate rows ([685d3c7](https://github.com/angular-ui/ui-grid/commit/685d3c798a3417a1963241e1c7763dc9e60f9d8d))
* **tree-base:** if parent exists in cache ([cf7a5bc](https://github.com/angular-ui/ui-grid/commit/cf7a5bc8ef4d592c0907a35df7779be00ba7feac))





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)


Expand Down
2 changes: 1 addition & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-ui-grid",
"version": "4.9.2",
"version": "4.9.1",
"homepage": "http://ui-grid.info",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion lerna.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"packages": [
"packages/*"
],
"version": "4.9.2"
"version": "4.9.1"
}
2 changes: 1 addition & 1 deletion package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ui-grid",
"version": "4.9.2",
"version": "4.9.1",
"description": "A data grid for Angular",
"directories": {
"test": "test"
Expand Down
8 changes: 0 additions & 8 deletions packages/auto-resize/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/auto-resize





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/auto-resize
Expand Down
2 changes: 1 addition & 1 deletion packages/auto-resize/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/auto-resize/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/auto-resize",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides auto-resizing functionality to UI-Grid",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
8 changes: 0 additions & 8 deletions packages/cellnav/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/cell-nav





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/cell-nav
Expand Down
2 changes: 1 addition & 1 deletion packages/cellnav/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/cellnav/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/cell-nav",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides cell navigation functionality to UI-Grid",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
11 changes: 0 additions & 11 deletions packages/core/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)


### Bug Fixes

* 🐛 update rtl support function to fix rtl support ([75580b8](https://github.com/angular-ui/ui-grid/commit/75580b88c46a36029b3abb3b57eaccf1928c22ad))





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/core/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ui-grid/core",
"version": "4.9.2",
"version": "4.9.1",
"description": "A data grid for Angular",
"main": "index.js",
"dependencies": {
Expand Down
8 changes: 0 additions & 8 deletions packages/edit/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/edit





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/edit
Expand Down
2 changes: 1 addition & 1 deletion packages/edit/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/edit/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/edit",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides cell editing capability to ui.grid",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
8 changes: 0 additions & 8 deletions packages/empty-base-layer/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/empty-base-layer





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/empty-base-layer
Expand Down
2 changes: 1 addition & 1 deletion packages/empty-base-layer/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/empty-base-layer/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/empty-base-layer",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides the ability to have the background of the ui-grid be empty rows",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
8 changes: 0 additions & 8 deletions packages/expandable/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/expandable





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/expandable
Expand Down
2 changes: 1 addition & 1 deletion packages/expandable/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/expandable/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/expandable",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides the ability to create subgrids inside ui-grid",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
11 changes: 0 additions & 11 deletions packages/exporter/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)


### Bug Fixes

* pass both tree parent nodes and children nodes when exporting ([3a5ac8a](https://github.com/angular-ui/ui-grid/commit/3a5ac8adf83051b48081b2cc5d9d1bae77e5ef86)), closes [#7127](https://github.com/angular-ui/ui-grid/issues/7127) [#6819](https://github.com/angular-ui/ui-grid/issues/6819)





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/exporter/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/exporter/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/exporter",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides the ability to export data from ui-grid",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x",
"csv-js": "~1.0.0",
"excel-builder": "~2.0.2",
Expand Down
8 changes: 0 additions & 8 deletions packages/grouping/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/grouping





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/grouping
Expand Down
2 changes: 1 addition & 1 deletion packages/grouping/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/grouping/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "@ui-grid/grouping",
"version": "4.9.2",
"version": "4.9.1",
"description": "This module provides ui-grid with grouping of rows based on the data in them",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/tree-base": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"@ui-grid/tree-base": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
8 changes: 0 additions & 8 deletions packages/i18n/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/i18n





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/i18n
Expand Down
2 changes: 1 addition & 1 deletion packages/i18n/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/i18n/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "@ui-grid/i18n",
"version": "4.9.2",
"version": "4.9.1",
"description": "This package provides various language translations for ui-grid",
"main": "index.js",
"dependencies": {
"@ui-grid/core": "^4.9.2",
"@ui-grid/core": "^4.9.1",
"angular": ">=1.4.0 1.8.x"
},
"publishConfig": {
Expand Down
8 changes: 0 additions & 8 deletions packages/importer/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,6 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.9.2](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.2) (2020-12-01)

**Note:** Version bump only for package @ui-grid/importer





## [4.9.1](https://github.com/angular-ui/ui-grid/compare/v4.9.0...v4.9.1) (2020-10-26)

**Note:** Version bump only for package @ui-grid/importer
Expand Down
2 changes: 1 addition & 1 deletion packages/importer/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

10 comments on commit 3a4a27f

@Scrum
Copy link
Contributor

@Scrum Scrum commented on 3a4a27f Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mportuga why did you reverts commit ?

@mportuga
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this was not an actual release that made it to mom or bower

@Scrum
Copy link
Contributor

@Scrum Scrum commented on 3a4a27f Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this was not an actual release that made it to mom or bower

it was a full release with fixes cf7a5bc 685d3c7 daaa3cb

@mportuga
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did not make it to mom, therefore not a valid release. And you don't have the repository permission to make releases

@Scrum
Copy link
Contributor

@Scrum Scrum commented on 3a4a27f Jan 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy was performed according to the instructions and I do not need rights for the release. all deploy keys are stored in CI.

You can also make sure that the latest version of the package is on CDN https://cdn.jsdelivr.net/gh/angular-ui/bower-ui-grid/ui-grid.min.js

What does it mean mom ?

@mportuga
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, part of the release yes, but you miss out on NPM, one of our bigger sources of users, in the future, please let me or one of the other maintainers that have access to publish on NPM handle the release

@Scrum
Copy link
Contributor

@Scrum Scrum commented on 3a4a27f Jan 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you reverser your commits and publish changes to the NPM?

Well, part of the release yes, but you miss out on NPM, one of our bigger sources of users, in the future, please let me or one of the other maintainers that have access to publish on NPM handle the release

Gladly if the reaction of other maintainers is more reactive.

Could you provide me with the same access to NPM to be able to timely publish critical changes ?. The reaction of the maintainers is critically low

@Scrum
Copy link
Contributor

@Scrum Scrum commented on 3a4a27f Jan 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mportuga The PRs are awaiting a resolution due to the ambiguity with this issue. Can you tell me something on my part is required to speed up the process on this issue?

@mportuga
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, i can't give you permissions at this moment, i plan on making this release over the weekend. However, i will look into seeing if I can at least give you a little bit more access, such as reviewer privelages. I just can't provide you with release privelages.

@Scrum
Copy link
Contributor

@Scrum Scrum commented on 3a4a27f Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment I have all the necessary rights in the repository, all that prevents me from making a full-fledged release is the right to publish in the npm

Please sign in to comment.